Skip to content

GH-51687: [C++] Skipt tests that require threads if ARROW_ENABLE_THREADING=OFF #51688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanmato1984 merged 1 commit into from
Oct 2, 2026
Merged

GH-51687: [C++] Skipt tests that require threads if ARROW_ENABLE_THREADING=OFF #51688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cpp/src/arrow/util/async_generator_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,9 @@ TEST_F(MergedGeneratorErrorHookTest, OuterErrorToWaiterNotOvertakenByLaterPull)
// receives the error has completed, even when it is requested while the generator is
// already completing.
TEST_F(MergedGeneratorErrorHookTest, InnerErrorToWaiterNotOvertakenDuringCompletion) {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif
auto failing = Future<TestInt>::Make();
AsyncGenerator<TestInt> failing_sub = [failing]() { return failing; };
std::vector<AsyncGenerator<TestInt>> subs = {failing_sub};
Expand All @@ -994,6 +997,9 @@ TEST_F(MergedGeneratorErrorHookTest, InnerErrorToWaiterNotOvertakenDuringComplet
}

TEST_F(MergedGeneratorErrorHookTest, OuterErrorToWaiterNotOvertakenDuringCompletion) {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif
auto failing = Future<AsyncGenerator<TestInt>>::Make();
AsyncGenerator<AsyncGenerator<TestInt>> source = [failing]() { return failing; };
MergedGenerator<TestInt> gen(std::move(source), 1);
Expand All @@ -1011,6 +1017,9 @@ TEST_F(MergedGeneratorErrorHookTest, OuterErrorToWaiterNotOvertakenDuringComplet
}

TEST_F(MergedGeneratorErrorHookTest, ClaimedErrorNotOvertakenDuringCompletion) {
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading support";
#endif
auto failing = Future<TestInt>::Make();
AsyncGenerator<TestInt> failing_sub = [failing]() { return failing; };
std::vector<AsyncGenerator<TestInt>> subs = {MakeVectorGenerator<TestInt>({TestInt(1)}),
Expand Down
Loading