Skip to content

GH-51641: [C++][Parquet] fix int32 offset overflow in dictionary SetDict #51642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arawoof06 wants to merge 1 commit into from
Closed

GH-51641: [C++][Parquet] fix int32 offset overflow in dictionary SetDict #51642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cpp/src/parquet/decoder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,12 @@ void DictDecoderImpl<ByteArrayType>::SetDict(TypedDecoder<ByteArrayType>* dictio
for (int i = 0; i < dictionary_length_; ++i) {
total_size += dict_values[i].len;
}
// Values are addressed by int32 offsets, so >2GB wraps the offset below and the
// memcpy loop writes out of bounds.
if (ARROW_PREDICT_FALSE(total_size > std::numeric_limits<int32_t>::max())) {
throw ParquetException(
"BYTE_ARRAY dictionary has more than 2GB of data, which is not supported");
}
PARQUET_THROW_NOT_OK(byte_array_data_->Resize(total_size,
/*shrink_to_fit=*/false));
PARQUET_THROW_NOT_OK(byte_array_offsets_->Resize(
Expand Down Expand Up @@ -1100,7 +1106,9 @@ inline void DictDecoderImpl<FLBAType>::SetDict(TypedDecoder<FLBAType>* dictionar
PARQUET_THROW_NOT_OK(byte_array_data_->Resize(total_size,
/*shrink_to_fit=*/false));
uint8_t* bytes_data = byte_array_data_->mutable_data();
for (int32_t i = 0, offset = 0; i < dictionary_length_; ++i, offset += fixed_len) {
// offset is 64-bit: total_size can exceed 2GB and a 32-bit accumulator would wrap
// and make the memcpy below write out of bounds.
for (int64_t i = 0, offset = 0; i < dictionary_length_; ++i, offset += fixed_len) {
memcpy(bytes_data + offset, dict_values[i].ptr, fixed_len);
dict_values[i].ptr = bytes_data + offset;
}
Expand Down
Loading