Skip to content

GH-51485: [C++] Fix SC2086 errors in cpp/examples/tutorial_examples directory #51486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 5 commits into from
Sep 28, 2026
Merged

GH-51485: [C++] Fix SC2086 errors in cpp/examples/tutorial_examples directory #51486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15be44f
GH-51485: [Dev][Tutorial] Fix SC2086 errors in cpp/examples/tutorial_…
hiroyuki-sato Sep 24, 2026
26b4792
GH-51485: [Dev][Tutorial] Fix SC2086 errors in cpp/examples/tutorial_…
hiroyuki-sato Sep 24, 2026
1929686
Convert variable into an array
hiroyuki-sato Sep 25, 2026
4267a0c
Fix shellcheck
hiroyuki-sato Sep 25, 2026
b01de08
Convert variable into an array
hiroyuki-sato Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ repos:
?^ci/.*\.sh$|
?^cpp/build-support/.*\.sh$|
?^cpp/examples/minimal_build/run\.sh$|
?^cpp/examples/tutorial_examples/run\.sh$|
?^cpp/examples/tutorial_examples/.*\.sh$|
?^cpp/src/.*\.sh$|
?^cpp/thirdparty/download_dependencies\.sh$|
?^dev/release/05-binary-upload\.sh$|
Expand Down
12 changes: 8 additions & 4 deletions cpp/examples/tutorial_examples/build_arrow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@ set -ex

NPROC=$(nproc)

mkdir -p $ARROW_BUILD_DIR
pushd $ARROW_BUILD_DIR
mkdir -p "$ARROW_BUILD_DIR"
pushd "$ARROW_BUILD_DIR"

# Convert the space-separated CMake options into a Bash array.
# This avoids ShellCheck SC2086 and preserves argument boundaries.
read -r -a ARROW_CMAKE_OPTIONS_ARRAY <<< "$ARROW_CMAKE_OPTIONS"

# Enable the CSV reader as it's used by the example third-party build
cmake /arrow/cpp \
Expand All @@ -30,9 +34,9 @@ cmake /arrow/cpp \
-DARROW_FILESYSTEM=ON \
-DARROW_PARQUET=ON \
-DARROW_MIMALLOC=OFF \
$ARROW_CMAKE_OPTIONS
"${ARROW_CMAKE_OPTIONS_ARRAY[@]}"

make -j$NPROC
make -j"$NPROC"
make install

popd
10 changes: 7 additions & 3 deletions cpp/examples/tutorial_examples/build_example.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@

set -ex

mkdir -p $EXAMPLE_BUILD_DIR
pushd $EXAMPLE_BUILD_DIR
mkdir -p "$EXAMPLE_BUILD_DIR"
pushd "$EXAMPLE_BUILD_DIR"

cmake /io $EXAMPLE_CMAKE_OPTIONS
# Convert the space-separated CMake options into a Bash array.
# This avoids ShellCheck SC2086 and preserves argument boundaries.
read -r -a EXAMPLE_CMAKE_OPTIONS_ARRAY <<< "$EXAMPLE_CMAKE_OPTIONS"

cmake /io "${EXAMPLE_CMAKE_OPTIONS_ARRAY[@]}"
make

popd
Loading