Repository navigation
GH-51245: [C++][Parquet][FOLLOWUP] Add support for LLVM 23.1 - #51468
Merged
Merged
Conversation
HuaHuaY
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds LLVM 23.1 support by updating Parquet test utilities and removing unused test code.
Changes:
- Updates template helper linkage.
- Removes an unused comparison helper.
- Updates decimal test utilities.
| File | Description |
|---|---|
cpp/src/parquet/test_util.h |
Updates template helper linkage. |
cpp/src/parquet/column_reader_test.cc |
Removes unused comparison helper. |
cpp/src/parquet/arrow/test_util.h |
Updates decimal helper linkage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wgtmac
approved these changes
Sep 23, 2026
github-actions
Bot
added
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add support for LLVM 23.1.
My mistake. In the previous PR, I used the
ninja-debug-gandivaCMake preset but didn't notice that some Parquet tests weren't being compiled; consequently, certain compilation errors within the Parquet component went undetected. This time I used theninja-debugpreset. I'm not sure if there are compilation errors in other presets—I don't use them often, and CI doesn't check them either—so we'll just fix them if we run into them.What changes are included in this PR?
Remove static from some template functions in header files because LLVM 23 added
-Wunused-templateto-Wall.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: