Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion python/pyarrow/_dataset_parquet.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,8 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
"coerce_timestamps",
"allow_truncated_timestamps",
"use_compliant_nested_type",
"store_schema",
"write_time_adjusted_to_utc",
}

setters = set()
Expand Down Expand Up @@ -661,6 +663,7 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
sorting_columns=self._properties["sorting_columns"],
store_decimal_as_integer=self._properties["store_decimal_as_integer"],
use_content_defined_chunking=self._properties["use_content_defined_chunking"],
bloom_filter_options=self._properties["bloom_filter_options"],
)

def _set_arrow_properties(self):
Expand All @@ -677,7 +680,9 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
writer_engine_version="V2",
use_compliant_nested_type=(
self._properties["use_compliant_nested_type"]
)
),
store_schema=self._properties["store_schema"],
write_time_adjusted_to_utc=self._properties["write_time_adjusted_to_utc"],
)

def _set_encryption_config(self):
Expand Down Expand Up @@ -706,6 +711,7 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
coerce_timestamps=None,
allow_truncated_timestamps=False,
use_compliant_nested_type=True,
store_schema=True,
encryption_properties=None,
write_batch_size=None,
dictionary_pagesize_limit=None,
Expand All @@ -715,6 +721,8 @@ cdef class ParquetFileWriteOptions(FileWriteOptions):
sorting_columns=None,
store_decimal_as_integer=False,
use_content_defined_chunking=False,
write_time_adjusted_to_utc=False,
bloom_filter_options=None,
)

self._set_properties()
Expand Down
2 changes: 2 additions & 0 deletions python/pyarrow/parquet/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,7 @@ def __init__(self, where, schema, filesystem=None,
store_decimal_as_integer=False,
write_time_adjusted_to_utc=False,
max_rows_per_page=None,
bloom_filter_options=None,
use_content_defined_chunking=False,
**options):
if use_deprecated_int96_timestamps is None:
Expand Down Expand Up @@ -1144,6 +1145,7 @@ def __init__(self, where, schema, filesystem=None,
store_decimal_as_integer=store_decimal_as_integer,
write_time_adjusted_to_utc=write_time_adjusted_to_utc,
max_rows_per_page=max_rows_per_page,
bloom_filter_options=bloom_filter_options,
use_content_defined_chunking=use_content_defined_chunking,
**options)
self.is_open = True
Expand Down
27 changes: 27 additions & 0 deletions python/pyarrow/tests/parquet/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,33 @@ def file_visitor(written_file):
assert paths_written_set == expected_paths


def test_write_table_options_in_make_write_options():
import pyarrow.dataset as ds

# Test write_table options are in sync with the dataset writer.
# Any option not in ParquetFileWriteOptions raises TypeError in make_write_options
not_writer_args = {"table", "where", "row_group_size", "filesystem", "flavor"}
options = {
name: parameter.default
for name, parameter in inspect.signature(pq.write_table).parameters.items()
if name not in not_writer_args
and parameter.kind != inspect.Parameter.VAR_KEYWORD
}
ds.ParquetFileFormat().make_write_options(**options)
Comment thread
tadeja marked this conversation as resolved.


def test_write_to_dataset_options(tempdir):
table = pa.table({"a": [1, 2, 3],
"t": pa.array([1, 2, 3], pa.time32("ms"))})
pq.write_to_dataset(table, tempdir, store_schema=False,
write_time_adjusted_to_utc=True,
bloom_filter_options={"a": True})
metadata = pq.read_metadata(next(tempdir.glob("*.parquet")))
assert b'ARROW:schema' not in (metadata.metadata or {})
assert 'isAdjustedToUTC=true' in str(metadata.schema.column(1).logical_type)
assert metadata.row_group(0).column(0).bloom_filter_offset is not None


@pytest.mark.parametrize("write_dataset_kwarg", (
("create_dir", True),
("create_dir", False),
Expand Down
Loading