GH-51367: [C++] Remove unused arrow::internal::LruCache and its tests/benchmarks - #51384
basantjamwal wants to merge 1 commit into
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
|
For ease of reference, this is the commit that originally introduced the Why was it introduced? I found this discussion and this dependent issue but no further references to the |
|
Caching some expensive compute kernel precomputations (such as compiling a regex) was the original intent but I then noticed two problems:
|
Closes #51367
Rationale for this change
No code within Arrow uses
arrow::internal::LruCache. Per discussion in#51328 (review comment r4027861697), removing this dead code along with
its tests and benchmarks.
What changes are included in this PR?
MemoizeLruThreadUnsafe — all unused outside this file and its tests)
Verified via
git grepacross cpp/ that nothing else references thiscode (gandiva's separate LRU cache in cpp/src/gandiva/lru_cache.h is
unrelated and untouched).
Supersedes #51371, which was opened with an empty diff due to a branch mix-up.
Are these changes tested?
Pure removal of unused code; no new tests needed. Relying on CI to
validate the build/test suite still passes.
Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: