Skip to content

GH-51297: [Dev] Fix SC2035 shellcheck errors in the cpp/src/arrow/vendored directory - #51298

Merged
kou merged 2 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-arrow-vendored-dir
Sep 18, 2026
Merged

kou merged 2 commits into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-arrow-vendored-dir

Conversation

@hiroyuki-sato

@hiroyuki-sato hiroyuki-sato commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Rationale for this change

  • Use ./*glob* or -- *glob* so names with dashes won't become options.
In cpp/src/arrow/vendored/fast_float/update.sh line 40:
sed -i.bak -E -e "s/v[0-9.]+/v${version}/g" *.h
                                            ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/fast_float/update.sh line 44:
    *.h
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/fast_float/update.sh line 45:
rm *.bak
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/datetime/update.sh line 48:
    *.{cpp,h,mm}
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/datetime/update.sh line 51:
    *.h
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/datetime/update.sh line 55:
rm *.bak
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 38:
rm *.cc *.h
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.
        ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 43:
sed -i.bak -E -e "s/v[0-9.]+/v${version}/g" *.md
                                            ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 49:
    *.{h,cc}
    ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.


In cpp/src/arrow/vendored/double-conversion/update.sh line 50:
rm *.bak
   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

For more information:
  https://www.shellcheck.net/wiki/SC2035 -- Use ./*glob* or -- *glob* so name...

What changes are included in this PR?

Use ./*glob instead of *glob

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #51297 has been automatically assigned in GitHub to PR creator.

@hiroyuki-sato
hiroyuki-sato marked this pull request as ready for review September 11, 2026 05:35
@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

I confirmed that the following command works in my local environment:

cd arrow/cpp/src/arrow/vendored
 ./datetime/update.sh 3.0.5
 ./double-conversion/update.sh 3.4.0
 ./fast_float/update.sh  8.2.10

@hiroyuki-sato

Copy link
Copy Markdown
Collaborator Author

@kou, @raulcd Please take a look this PR when you have a time.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 3208df1 into apache:main Sep 18, 2026
59 of 62 checks passed
@kou kou removed the awaiting review Awaiting review label Sep 18, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Sep 18, 2026
@hiroyuki-sato
hiroyuki-sato deleted the topic/shellcheck-arrow-vendored-dir branch September 18, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants