Skip to content

GH-51044: [Python] Reject read-only readinto destinations #51126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carrerasdarren-cell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-51044: [Python] Reject read-only readinto destinations #51126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/pyarrow/io.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,8 @@ cdef class NativeFile(_Weakrefable):
handle = self.get_input_stream()

py_buf = py_buffer(b)
if not py_buf.buffer.get().is_mutable():
raise TypeError("readinto() argument must be a writable buffer")
buf_len = py_buf.size
buf = py_buf.buffer.get().mutable_data()

Expand Down
7 changes: 7 additions & 0 deletions python/pyarrow/tests/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,13 @@ def test_python_file_readinto():
assert len(dst_buf) == length


@pytest.mark.parametrize("dst_buf", [b"a", memoryview(b"a")])
def test_native_file_readinto_rejects_readonly_buffer(dst_buf):
with pa.BufferReader(b"x") as f:
with pytest.raises(TypeError, match="writable buffer"):
f.readinto(dst_buf)


def test_python_file_read_buffer():
length = 10
data = b'0123456798'
Expand Down