Bumping vendored uriparser - #51123
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
|
Thanks @imtherealnaska . Actually, this is a lot of additional vendored code and perhaps it would be better to make it a mandatory external dependency... What do you think @rok @kou ? |
|
Thanks for opening this @imtherealnaska ! |
|
uriparser has had security fixes, so yes. |
|
@pitrou Raul is away for some more time I think. |
Until Monday 7th I think. |
Yes , but I saw this done some time ago #5865 . If you would like to have an external dependency, I can work on that. |
|
@imtherealnaska we better wait for @kou to reply so we can decide on the direction. And thanks for being flexible regarding the approach! |
Sure. Happy to contribute |
+1 Let's do it. |
Rationale for this change
Bumping up the version of uriparser
What changes are included in this PR?
All files from upstream git tag
uriparser-1.0.2following the process incpp/src/arrow/vendored/uriparser/README.mdAre these changes tested?
Yes. No new tests were added.
Are there any user-facing changes?
No.
Help needed from reviewers
AI Usage :
Did a preliminary review with claude ,it suggested some licenses.txt has 0.9.3 wordings . Please let me know if that is something you would be interested in .