-
Notifications
You must be signed in to change notification settings - Fork 4.3k
GH-51037: [C++] Replace RapidJSON with simdjson in JSON parser #51038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
95a3b62
d697915
475e7cd
8dcd806
b939078
d5b27fd
bc1b9d7
3eacd65
27d40e6
f247da7
78a6431
59bee5b
18d1492
d08838e
89e0a6f
d07e7ef
ff707ad
7b0d5bf
fbe9f5b
b27b054
c11ee21
6b0b6a4
1c977a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2837,6 +2837,9 @@ function(build_simdjson) | |
|
|
||
| prepare_fetchcontent() | ||
|
|
||
| # Keep simdjson's threading configuration consistent with Arrow's, | ||
| # which is required for Emscripten where Arrow threading is disabled. | ||
| set(SIMDJSON_ENABLE_THREADS ${ARROW_ENABLE_THREADING}) | ||
|
Comment on lines
+2840
to
+2842
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/simdjson/simdjson/blob/master/doc/iterate_many.md
Note the code section for this auto-detection: So even if we do not set the cmake option |
||
| # simdjson enables precompiled headers unconditionally. | ||
| # Recompiling simdjson.cpp against it produces differing artifacts | ||
| # Disable precompiled headers to avoid reproducible build failures. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.