Skip to content

GH-51018: [C++] Fix indices_nonzero segfault on chunkless ChunkedArray #51021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

GH-51018: [C++] Fix indices_nonzero segfault on chunkless ChunkedArray #51021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/src/arrow/compute/kernels/vector_selection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,10 @@ Status DoNonZero(const std::vector<ArraySpan>& arrays, int64_t total_length,
UInt64Builder builder;
RETURN_NOT_OK(builder.Reserve(total_length));

NonZeroVisitor visitor(&builder, arrays);
RETURN_NOT_OK(VisitTypeInline(*arrays[0].type, &visitor));
if (!arrays.empty()) {
NonZeroVisitor visitor(&builder, arrays);
RETURN_NOT_OK(VisitTypeInline(*arrays[0].type, &visitor));
}
return builder.FinishInternal(out);
}

Expand Down
8 changes: 8 additions & 0 deletions cpp/src/arrow/compute/kernels/vector_selection_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2920,6 +2920,14 @@ TEST(TestIndicesNonZero, IndicesNonZero) {
actual, CallFunction("indices_nonzero", {static_cast<Datum>(chunked_arr_empty)}));
AssertArraysEqual(*ArrayFromJSON(uint64(), "[0, 2, 3, 5]"), *actual.make_array(),
/*verbose*/ true);

// chunked with zero chunks (GH-51018)
ChunkedArray chunked_arr_no_chunks({}, type);
ASSERT_OK_AND_ASSIGN(
actual,
CallFunction("indices_nonzero", {static_cast<Datum>(chunked_arr_no_chunks)}));
AssertArraysEqual(*ArrayFromJSON(uint64(), "[]"), *actual.make_array(),
/*verbose*/ true);
}
}

Expand Down
Loading