Skip to content

[Python][Annotations] Add pyrefly check to CI #51474

Open

Description

@rok

Describe the enhancement requested

Add pyrefly type check to the CI.
See also #49102 and #48622 (comment)

Component(s)

Python

Activity

  1. rok commented on Sep 23, 2026

    @rok
    MemberAuthor
  2. jorisvandenbossche commented on Sep 24, 2026

    @jorisvandenbossche
    Member

    Is it needed to add yet another type checker? (the more type checkers, the more maintenance effort to keep them all happy)
    I find https://pyrefly.org/blog/too-many-type-checkers/ an interesting resource, which essentially says it is fine to run just one type checker on your code, but run multiple on the tests (as a way to test your public API with as many type checkers as possible, but for internal development just choose one).

    I know we don't yet actually run the type checkers on the code (or tests, since those directories are excluded), but something to think about for when are planning to enable this.

  3. rok commented on Sep 24, 2026

    @rok
    MemberAuthor

    @jorisvandenbossche that approach seems reasonable. Also I suppose work on the annotations will show how problematic multi-typechecker setup would be. And I suppose we can postpone any decisions until then.

  4. samwgoldman commented on Sep 28, 2026

    @samwgoldman

    Whatever you decide to do, let me know if I can support in any way. I put up a PR to add Pyrefly, if you decide to go that direction. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions