Skip to content

[C++] Necessity of the build-support scripts in the cpp directory (ShellCheck) #50883

Closed

Description

@hiroyuki-sato

Describe the enhancement requested

This is the sub issue #44748.

It looks like the following three files are not referenced anywhere else in this project.
Would it be safe to remove them, or should I fix the ShellCheck errors instead?
Depending on the answer, I'll adjust the contents of the PR accordingly.

  • cpp/build-support/trim-boost.sh
  • cpp/build-support/update-flatbuffers.sh
  • cpp/build-support/vendor-flatbuffers.sh

Component(s)

C++

Activity

  1. kou commented on Aug 16, 2026

    @kou
    Member

    We can remove trim-boost.sh.

    Let's keep *-flatbuffer.sh for now. We may update Flatbuffers related files later #33031. Or we may support system Flatbuffers #45636.

  2. added a commit that references this issue on Aug 16, 2026
  3. hiroyuki-sato commented on Aug 16, 2026

    @hiroyuki-sato
    CollaboratorAuthor

    @kou Thank you for your comment. I created #50885, and I'll create another issue for the *-flatbuffer.sh scripts.

  4. added a commit that references this issue on Aug 16, 2026
  5. kou commented on Aug 16, 2026

    @kou
    Member

    Issue resolved by pull request 50885
    #50885

  6. added this to the 26.0.0 milestone on Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions