Repository navigation
[C++] C++20: use starts_with/ends_with methods #48592
Description
Describe the enhancement requested
std::string and std::string_view have gained starts_with and ends_with methods that can allow some code simplification (and we can also remove our StartsWith / EndsWith helper functions).
Component(s)
C++
Activity
jonahkel commentedon Dec 18, 2025
Hi, I'd like to implement this enhancement as my first OSS contribution. Is there anything I should know before I begin?
jonahkel commentedon Dec 18, 2025
take
pitrou commentedon Dec 19, 2025
Yes, of course, feel free to submit a PR @jonahkel
jonahkel commentedon Dec 19, 2025
Are all of the files that need to be changed in cpp/ ?
Also, is it sufficient for me to run the cpp unit tests and style checks after I make my changes?
jonahkel commentedon Dec 19, 2025
I made the changes but I'm having trouble testing them. When building using the cmake ninja-debug-basic preset I expect unit test files to be generated in build/debug. However, no tests are generated, so ctest is failing.
pitrou commentedon Dec 20, 2025
I think so, but you can check by searching through the codebase.
It should. More builds will be run once you open a PR.
pitrou commentedon Dec 20, 2025
ctestshould work, but you have to run it from thebuilddirectory (or you can pass the directory through a ctest option, I don't remember which one).Soumyadeep-4704 commentedon Dec 21, 2025
I want to work on this and kickstart my journey in the open-source world. Can I work on this?
jonahkel commentedon Dec 21, 2025
I've already made the necessary changes. There's just one failing test I need to address and then it will be done.
GH-48592: [C++] Use starts_with/ends_with methods (#48614)
pitrou commentedon Jan 5, 2026
Issue resolved by pull request 48614
#48614
apacheGH-48592: [C++] Use starts_with/ends_with methods (apache#48614)