Repository navigation
fix: Read empty array test offsets at their native width - #997
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
=======================================
Coverage 78.58% 78.58%
=======================================
Files 106 106
Lines 17173 17173
Branches 2045 2045
=======================================
Hits 13495 13495
Misses 2427 2427
Partials 1251 1251 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paleolimbot
marked this pull request as ready for review
October 26, 2026 03:10
paleolimbot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest verify run (https://github.com/apache/arrow-nanoarrow/actions/runs/40148573730) fails on s390x because ArrayTestFinishBuildingEmptyArrayOffsets copies four bytes into an int64_t initialized to -1, then truncates the untouched low bytes on big-endian systems. Read each offset into an integer of the matching width.
Reproduced all four failing assertions under QEMU s390x before the fix. Afterward, the core CTest suite passes on s390x and native x86-64: 287 passed, three skipped on each. clang-format and git diff --check pass. The full release verification workflow was not rerun.