Skip to content

test: Give each C data integration test its own temp file #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rustyconover wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Give each C data integration test its own temp file #969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/nanoarrow/integration/c_data_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

#include <cstdio>
#include <fstream>
#include <string>

#include <gtest/gtest.h>

Expand All @@ -25,19 +26,26 @@
#include "c_data_integration.h"

// Not a true tempfile (writes to working directory), but is possibly more
// portable than mkstemp()
// portable than mkstemp(). The name includes the current test's name because ctest
// runs each test as a separate process, in parallel with the others: with a shared
// name, one test can overwrite or remove another test's file.
class TempFile {
public:
const char* name() { return name_; }
TempFile()
: name_(std::string("c_data_integration.") +
::testing::UnitTest::GetInstance()->current_test_info()->name() +
".tmp.json") {}

const char* name() { return name_.c_str(); }

~TempFile() {
if (std::remove(name_) != 0) {
if (std::remove(name_.c_str()) != 0) {
std::cerr << "Failed to remove '" << name_ << "'\n";
}
}

private:
const char* name_ = "c_data_integration.tmp.json";
std::string name_;
};

ArrowErrorCode WriteFileString(const std::string& content, const std::string& path) {
Expand Down
Loading