Skip to content

fix: preserve half-float subnormal values - #962

Merged
paleolimbot merged 1 commit into
apache:mainfrom
vera-rubin:fix/half-float-subnormals
Oct 16, 2026
Merged

paleolimbot merged 1 commit into
apache:mainfrom
vera-rubin:fix/half-float-subnormals

Conversation

@vera-rubin

Copy link
Copy Markdown
Contributor

The half-float getter returned incorrect values for nonzero subnormals, and the appender stored them as zero. Normalize subnormal decoding and restore the implicit leading bit when encoding.

Regression and all 63,488 finite binary16 encodings pass. Serial CTest: 371 passed, 16 optional compression skips.

AI-assisted, reviewed by me.

Fixes #961

— ChipLab

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.27%. Comparing base (ea215b0) to head (c8fbff3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
+ Coverage   78.24%   78.27%   +0.02%     
==========================================
  Files         106      106              
  Lines       16867    16874       +7     
  Branches     1993     1996       +3     
==========================================
+ Hits        13198    13208      +10     
+ Misses       2437     2435       -2     
+ Partials     1232     1231       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paleolimbot paleolimbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paleolimbot
paleolimbot merged commit e5f3d0a into apache:main Oct 16, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C] Half-float getter and appender return wrong values for nonzero subnormals

3 participants