Repository navigation
fix: preserve half-float subnormal values - #962
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
+ Coverage 78.24% 78.27% +0.02%
==========================================
Files 106 106
Lines 16867 16874 +7
Branches 1993 1996 +3
==========================================
+ Hits 13198 13208 +10
+ Misses 2437 2435 -2
+ Partials 1232 1231 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The half-float getter returned incorrect values for nonzero subnormals, and the appender stored them as zero. Normalize subnormal decoding and restore the implicit leading bit when encoding.
Regression and all 63,488 finite binary16 encodings pass. Serial CTest: 371 passed, 16 optional compression skips.
AI-assisted, reviewed by me.
Fixes #961
— ChipLab