Repository navigation
fix(ipc): handle missing flatbuffer tables and dictionary flags - #960
Merged
paleolimbot merged 3 commits intoOct 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
+ Coverage 78.20% 78.24% +0.04%
==========================================
Files 106 106
Lines 16851 16867 +16
Branches 1988 1993 +5
==========================================
+ Hits 13178 13198 +20
+ Misses 2438 2437 -1
+ Partials 1235 1232 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paleolimbot
marked this pull request as ready for review
October 11, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject IPC messages with missing Field.type, Message.header, or DictionaryBatch.data tables. Validate nested dictionary record-batch node and buffer counts before accessing their vectors, returning EINVAL for missing or mismatched vectors. Preserve outer-field nullability while keeping dictionary values nullable.
Add regressions for malformed tables, missing/empty/incorrect vector counts through both dictionary decoding APIs, recovery after rejected batches, default int32 dictionary indices, and non-nullable dictionary round trips.
Closes #958
Closes #959
Tests: 102 IPC-related CTests passed with ZSTD and LZ4 enabled; pre-commit checks passed. The new vector-count regression reproduces the assertion failure before the fix.