Skip to content

fix(python): Check error code for ArrowMetadataReaderRead in Python bindings #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paleolimbot merged 1 commit into from
Jul 22, 2026
Merged

fix(python): Check error code for ArrowMetadataReaderRead in Python bindings #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/src/nanoarrow/_schema.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,11 @@ cdef class SchemaMetadata:
The result may contain duplicate keys if they exist in the metadata."""
cdef ArrowStringView key
cdef ArrowStringView value
cdef int code
self._init_reader()
while self._reader.remaining_keys > 0:
ArrowMetadataReaderRead(&self._reader, &key, &value)
code = ArrowMetadataReaderRead(&self._reader, &key, &value)
Error.raise_error_not_ok("ArrowMetadataReaderRead()", code)
key_obj = PyBytes_FromStringAndSize(key.data, key.size_bytes)
value_obj = PyBytes_FromStringAndSize(value.data, value.size_bytes)
yield key_obj, value_obj
Expand Down