Skip to content

fix: Ensure metal device's align buffers exports aligned buffer pointers correctly - #904

Merged
paleolimbot merged 2 commits into
apache:mainfrom
paleolimbot:fix-metal-cuda-buffer-test
Jul 15, 2026
Merged

paleolimbot merged 2 commits into
apache:mainfrom
paleolimbot:fix-metal-cuda-buffer-test

Conversation

@paleolimbot

Copy link
Copy Markdown
Member

The existing implementation of ArrowDeviceMetalAlignArrayBuffers() did not properly flush the buffer pointer in the ArrowArray, so the array->buffers[i] pointer pointed to potentially freed data. This is not a commonly (if ever) used function.

@codecov-commenter

codecov-commenter commented Jul 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.59%. Comparing base (f11d517) to head (c7d40ac).
⚠️ Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
- Coverage   79.96%   78.59%   -1.38%     
==========================================
  Files         105      106       +1     
  Lines       15461    16128     +667     
  Branches     1738     1858     +120     
==========================================
+ Hits        12364    12675     +311     
- Misses       1998     2286     +288     
- Partials     1099     1167      +68     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paleolimbot
paleolimbot merged commit 960122f into apache:main Jul 15, 2026
42 checks passed
@paleolimbot
paleolimbot deleted the fix-metal-cuda-buffer-test branch July 15, 2026 19:55
@paleolimbot paleolimbot added this to the nanoarrow 0.9.0 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants