Repository navigation
Conversation
getVisitFn used `instanceof DataType`, which fails for a type created by another copy of the library, such as a duplicate install or the CommonJS and ES module builds loaded together. The visitor fell through to Type.NONE, so the IPC writer silently wrote a stream with no types and empty bodies. Use DataType.isDataType(), which works across copies, and add a test that writes tables through a second copy of the library. Fixes apache#496
Member
|
Looks good to me! A couple of nits found with help from Claude Opus 5.5:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
getVisitFn used
instanceof DataType, which fails for a type created by another copy of the library, such as the CommonJS and ES module builds loaded side by side. The visitor fell through toType.NONE, so the IPC writer silently wrote a stream with no types and empty bodies.Applies a fix to use
DataType.isDataType()introduced in #377, which works across copies, and adds a test that writes tables through a second copy of the library.Closes #496