feat: update site to astro platform - #204
Open
lxfu1 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
馃數 Needs a closer look
It鈥檚 a major platform migration with a large new homepage surface area and includes confirmed rendering/SEO-impacting issues that should be resolved and revalidated end-to-end.
Pull request overview
This PR migrates the AntV website to the Astro-based @antv/site platform, introducing a new Astro homepage slot and reworking TypeScript/build tooling to match the new stack.
Changes:
- Switch project tooling to Astro +
@antv/site(newastro.config.mjs, updatedpackage.json, updatedtsconfig.json). - Add new homepage implementation (
site/Home.astro) and supporting home data/assets. - Update content configuration and documentation frontmatter to integrate with Astro content.
File summaries
| File | Description |
|---|---|
| tsconfig.json | Adopt Astro strict TS config and narrow include/exclude to the new Astro sources. |
| src/content.config.ts | Define Astro content collections using @antv/site loaders/schema. |
| site/Home.astro | New Astro homepage slot implementation with inline script/styles. |
| site/data/link-charts.json | Update/remove showcase links for the new site content. |
| site/data/home.ts | Add structured home page data (updates, solutions, showcases, etc.). |
| site/assets/home/treemap.svg | Add new home decorative asset. |
| site/assets/home/pie.svg | Add new home decorative asset. |
| site/assets/home/column.svg | Add new home decorative asset. |
| site/assets/home/ava.svg | Add new home visual asset. |
| site/assets/home/antv.svg | Add new home visual asset. |
| README.md | Update contributor instructions to pnpm + Astro scripts. |
| public/CNAME | Configure the custom domain for deployment. |
| package.json | Switch to Astro scripts, pnpm, ESM module type, and updated dependencies. |
| docs/specification/principles/basic.en.md | Add frontmatter metadata for the docs system. |
| astro.config.mjs | Introduce @antv/site configuration and wire the home slot to site/Home.astro. |
| .gitignore | Update ignored build artifacts for Astro / @antv/site. |
Review details
- Files reviewed: 9/26 changed files
- Comments generated: 3
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+4
to
+8
| site: { | ||
| title: 'AntV', | ||
| origin: 'https://antv.antgroup.com', | ||
| repository: 'https://github.com/antvis/antvis.github.io', | ||
| defaultLocale: 'zh', |
Comment on lines
+931
to
+933
| .antv-solution-icon img { | ||
| object-fit: conver; | ||
| } |
Comment on lines
+1111
to
+1114
| white-space: nowrap; | ||
| text-align: center; | ||
| background: rgba(107, 34, 255, 8%) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.