fix(server): port eval soft/hard think-close reply budgets - #958
Open
paride-cmd wants to merge 1 commit into
Open
fix(server): port eval soft/hard think-close reply budgets#958paride-cmd wants to merge 1 commit into
paride-cmd wants to merge 1 commit into
Conversation
HTTP callers could spend the entire max_tokens budget inside <think> and never terminate with an answer. Port ds4-eval's soft/hard reply budget controller to ds4-server with the same defaults and CLI flags so generation forces </think> while tokens remain for a reply. Fixes antirez#895
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #895
Test plan
AI usage disclosure: YES — assisted by Cursor agent; logic mirrored from `ds4_eval.c` and covered by new parse/forced-token unit tests.
Made with Cursor