fix(metal): coalesce adjacent --layers model map spans - #957
Open
paride-cmd wants to merge 1 commit into
Open
Conversation
--layers built one Metal no-copy buffer per isolated tensor span, so a per-host shard that already covered the whole file mapped as ~156 disjoint buffers and decode fell by ~77x. Merge abutting spans (with page/64KiB gap slop) and map coalesced ranges with the overlapping-view path used without --layers. Fixes antirez#845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #845
Test plan
AI usage disclosure: YES — assisted by Cursor agent; change reviewed against #845 measurements and existing Metal map comments.
Made with Cursor