Skip to content

server: advertise loaded vision input capability #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apetersson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

server: advertise loaded vision input capability #940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions ds4_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13437,7 +13437,8 @@ typedef struct {
} client_arg;

static void append_model_json_values(buf *b, const char *id, const char *name,
int ctx, int default_tokens) {
int ctx, int default_tokens,
bool has_vision) {
const int max_completion = default_tokens < ctx ? default_tokens : ctx;
buf_printf(b,
"{\"id\":");
Expand All @@ -13450,6 +13451,7 @@ static void append_model_json_values(buf *b, const char *id, const char *name,
json_escape(b, name);
buf_printf(b,
","
"\"input\":[\"text\"%s],"
"\"context_length\":%d,"
"\"top_provider\":{"
"\"context_length\":%d,"
Expand All @@ -13468,6 +13470,7 @@ static void append_model_json_values(buf *b, const char *id, const char *name,
"\"seed\","
"\"stream\","
"\"reasoning_effort\"]}",
has_vision ? ",\"image\"" : "",
ctx,
ctx,
max_completion);
Expand All @@ -13478,7 +13481,8 @@ static void append_model_json(buf *b, const server *s, const char *id) {
id,
ds4_engine_model_name(s->engine),
s->ctx_size,
s->default_tokens);
s->default_tokens,
ds4_engine_has_vision(s->engine));
}

static bool send_model(server *s, int fd, const char *id) {
Expand Down Expand Up @@ -17919,23 +17923,26 @@ static void test_tool_history_validation_handles_large_replays(void) {
chat_msgs_free(&anthropic);
}

static void test_model_metadata_clamps_completion_to_context(void) {
static void test_model_metadata_reports_input_and_clamps_completion(void) {
buf b = {0};
append_model_json_values(&b, "deepseek-v4-flash", "DeepSeek V4 Flash",
32768, 393216);
32768, 393216, true);
TEST_ASSERT(strstr(b.ptr, "\"id\":\"deepseek-v4-flash\"") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"name\":\"DeepSeek V4 Flash\"") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"context_length\":32768") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"max_completion_tokens\":32768") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"input\":[\"text\",\"image\"]") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"ignore_eos\"") != NULL);
buf_free(&b);

append_model_json_values(&b, "deepseek-v4-pro", "DeepSeek V4 Pro",
100000, 4096);
100000, 4096, false);
TEST_ASSERT(strstr(b.ptr, "\"id\":\"deepseek-v4-pro\"") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"name\":\"DeepSeek V4 Pro\"") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"context_length\":100000") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"max_completion_tokens\":4096") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"input\":[\"text\"]") != NULL);
TEST_ASSERT(strstr(b.ptr, "\"image\"") == NULL);
buf_free(&b);
}

Expand Down Expand Up @@ -19501,7 +19508,7 @@ static void ds4_server_unit_tests_run(void) {
test_json_string_handles_surrogates();
test_json_int_handles_non_finite_values();
test_tool_history_validation_handles_large_replays();
test_model_metadata_clamps_completion_to_context();
test_model_metadata_reports_input_and_clamps_completion();
test_live_prefix_rewind_target();
test_client_socket_nonblocking_flag();
test_client_disconnect_probe();
Expand Down