Repository navigation
fix: explain an installation found in the plain output, and take over one started from docker-compose.yaml - #15
Merged
Conversation
… one started from docker-compose.yaml The plain output, used in a terminal smaller than 80x22, never showed a question's help: an installation found was offered without saying what it was or why it could not be taken over. An installation started from docker-compose.yaml, compose.yaml or compose.yml is now read from that file and taken over; its first backup or upgrade renames it docker-compose.yml. A missing compose file or .env, and one root cannot read, each get their own explanation. One already at the version the installer installs is taken over without the word upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.yaml,compose.yamlorcompose.ymlis read from that file and can be taken over. Its first backup or upgrade renames itdocker-compose.yml, and moves aside any other compose file compose would read first..envand an unreadable one get their own explanations, naming the file; root is no longer told to run as root.Test plan
go vet,go test ./...as root and as a non-root userTestFindComposeYaml,TestProjectComposeFile,TestRepoComposeName,TestCurrent,TestReasonNamesTheFile,TestPlainHelpdocker-compose.yamlat 7.3.0, in a 12-row terminal: the 7.3.0 installer offers only Install beside it / Stop with no explanation; this branch explains it, takes it over and says there is nothing to upgrade