Repository navigation
feat: install a Runner on Kubernetes with the chart's runner mode - #14
Merged
Merged
Conversation
Kubernetes is offered for a Runner too: the Helm chart's runner mode, an RTE alone that dials the app (outbound), approved at once with a join token or by an admin, with the fingerprint of the token the installer made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Kubernetes is offered for a Runner too, no longer greyed out. It installs the Helm chart's runner mode (
runner.enabled, ansibleforms/helm-charts#109): an RTE alone that dials the app (outbound), with no app, database or ingress.applications.rte.token), so the summary shows its fingerprint for the admin who approves it; with a join token it is approved at once.Checklist
<type>/<description>and the title is a Conventional Commitgofmt -l .prints nothing, andgo vet ./...andgo test ./...pass (a new test for the Runner's chart values)internal/i18n/locales