Repository navigation
feat: say when Argo CD manages an AnsibleForms found on Kubernetes - #13
Merged
Merged
Conversation
Workloads an Argo CD Application manages (its tracking annotation or instance label, or the chart's labels without a Helm release) are listed as managed by Argo CD, with the Application's name. The installer leaves them alone and offers a new installation or to stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
An AnsibleForms on Kubernetes that an Argo CD Application manages is listed as managed by Argo CD (Application ), instead of "not a release of the ansibleforms Helm chart". The installer does nothing with it, explains that it is upgraded in Argo CD by changing the Application's chart version, and offers the usual choices: install a new one beside it, or stop.
Argo CD is recognised by its tracking-id annotation or its
argocd.argoproj.io/instancelabel, and, with Argo CD's default label tracking, by the chart's labels (managed-by Helm) on workloads that have no Helm release (Argo CD renders the chart itself).Checklist
<type>/<description>and the title is a Conventional Commitgofmt -l .prints nothing, andgo vet ./...andgo test ./...pass (a new test for both ways Argo CD marks its workloads)internal/i18n/locales