Skip to content

feat(plugin): let server plugins emit custom bus events - #46186

Closed
acramsay wants to merge 1 commit into
anomalyco:devfrom
acramsay:plugin-event-channel
Closed

feat(plugin): let server plugins emit custom bus events#46186
acramsay wants to merge 1 commit into
anomalyco:devfrom
acramsay:plugin-event-channel

Conversation

@acramsay

@acramsay acramsay commented Aug 29, 2026

Copy link
Copy Markdown

Issue for this PR

Partial implementation of #6330

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Add event.emit(type, properties) to PluginInput, publishing arbitrary namespaced event types (e.g. plugin..) on the Bus so clients can subscribe.

TUI plugins subscribe with api.event.on(...)

How did you verify your code works?

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

Server plugins can only receive events via the event hook, forcing
client/server plugin pairs into loopback HTTP workarounds. Add
event.emit(type, properties) to PluginInput, publishing arbitrary
namespaced event types (e.g. plugin.<pluginID>.<name>) on the Bus so
clients can subscribe.

TUI plugins subscribe with api.event.on(...) — loosen its typing so
custom types filter through with a PluginEvent fallback shape while
known SDK event types still narrow via Extract.
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Aug 29, 2026
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • "How did you verify your code works?" section is empty. Please explain how you tested.
  • Not all checklist items are checked. Please confirm you have tested locally and have not included unrelated changes.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

feat(plugin): add typed rpc and custom events (#46105)

This PR appears to be closely related as it also addresses custom events functionality for plugins. Both PRs deal with extending plugin capabilities to handle custom events, though PR #46105 mentions "typed rpc and custom events" while the current PR (#46186) specifically focuses on server plugins emitting custom bus events. These may be addressing overlapping concerns or the same feature from different angles.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Aug 29, 2026
@github-actions github-actions Bot closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant