fix(tui): handle wide Bengali graphemes - #46112
Open
Blackman99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46107
Type of change
What does this PR do?
Upgrades OpenTUI from 0.4.5 to 0.5.9 so terminals that use the
unicode-wideprofile measure complex Bengali graphemes correctly. The reported sample measured 12 cells before the upgrade and 18 cells after it, which prevents cumulative drift past the panel border.The dependency and plugin peer versions were updated with the repository's
upgrade-opentuiscript. A renderer regression test covers Bengali wrapping inside a border, a repeated render, terminal resize, and unchanged ASCII/CJK content.How did you verify your code works?
origin/devbecause the width method falls back tounicode, then passes with OpenTUI 0.5.9 andunicode-wide.bun run testinpackages/tui: 194 passed, 1 skipped.bun typecheckinpackages/tui,packages/plugin, andpackages/opencode.bun turbo typecheck: 30/30 packages passed.bun install --frozen-lockfile.Screenshots / recordings
N/A — terminal-specific rendering is covered by exact wide and resized frame assertions.
Checklist