fix(shell): bound Windows post-exit pipe draining - #46085
Draft
Hona wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Windows shell commands such as
bunx agent-browsercan leave descendants holding stdout/stderr open after the parent exits, preventing shell completion.Type of change
What does this PR do?
Adds a 200 ms, Windows-only drain window after parent exit. If inherited writers still prevent EOF, signal EOF on captured stdout/stderr so the existing output pump can finish and flush its file. Normal closure cancels the timer; POSIX is unchanged.
Nine added lines in the existing spawner. No new package, native code, dependencies, or test files.
This is a bounded cutoff, not a lossless-output guarantee: unread trailing output and later descendant writes can be excluded, and later writes can encounter a broken pipe. Saving captured output to a file does not recover bytes still in the pipes.
How did you verify your code works?
bun typecheckinpackages/util: passed.git diff --check: passed.bunx-> a harmless local fixture.EPIPE.agent-browser@0.35.1source prints command responses before CLI exit and uses null/private pipes for daemon/browser output. The actual browser was not executed because of the host workaround, so browser-specific runtime verification remains outstanding.Screenshots / recordings
Not a UI change.
Checklist