refactor(codemode): name only supported operations - #46082
Open
kitlangton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OpenAPI conversion generates operation names before checking whether their transport semantics are supported. Skipped operations discard that identifier sanitization and collision-search work without ever reserving the name.
What Changes
Move
operationPathimmediately before name registration, after the existing output, base URL, input, and security checks. Accepted names and collision suffixes remain identical because the naming sets do not change across the relocated code.Scope
One line moved and one focused test. Skip reasons/order, supported transport semantics, schemas, and execution are unchanged.
Verification
42 tests passed with 187 assertions before and after the move. The added case places an unsupported operation between accepted operations sharing an ID and checks exact names and the skipped record. Package typechecking, formatting, and whitespace checks passed.