refactor(codemode): avoid merging root definitions twice - #46081
Open
kitlangton wants to merge 1 commit into
Open
refactor(codemode): avoid merging root definitions twice#46081kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
JSON Schema rendering constructs a dictionary from root
definitionsand$defs, then immediately passes it torenderSchema, which copies and merges those same definitions again.What Changes
Start the root renderer with an empty inherited-definition context. Its existing schema-local merge remains the single owner of root definitions, preserving
$defsprecedence, nested shadowing, sibling isolation, and compact/pretty output.Scope
One production line plus focused tests. Effect schema document definitions in
toTypeScriptare unchanged; no schema, tool API, or interpreter changes.Verification
28 signature tests passed before and after the production change. Package typechecking, formatting, and whitespace checks passed. The new cases exercise legacy definitions,
$defsprecedence, and nested/sibling scope in both rendering modes.