refactor(util): reuse BOM-stripped text - #46078
Open
kitlangton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
syncBytesstrips leading byte-order marks, then callsjoin, which strips those same marks again. The second regex pass and temporary result object are redundant.What Changes
Build the canonical string directly from the already-stripped text and the requested BOM state. Public
joinbehavior remains unchanged for callers that pass unnormalized text.Scope
One production expression and a small parameterized test. Returned text, encoded bytes, input immutability, and the
undefinedresult for unchanged bytes are preserved.Verification
All 27 Util tests passed, including six new cases covering absent, single, and repeated leading BOMs, both desired states, and interior Unicode/BOM content. Package typechecking, formatting, and whitespace checks passed.