Tolerate Escape grab conflict on X11 listener - #107
Open
prathamdby wants to merge 1 commit into
Open
prathamdby wants to merge 1 commit into
prathamdby wants to merge 1 commit into
Conversation
- Warn and continue without Escape-cancel on grab conflicts - Keep non-conflict grab errors fatal with classifier tests - Cover conflicted Escape dictation with ignored X11 test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Anamoly team! I installed Hex on my machine, which runs on EndeavourOS, and I'm using i3wm with the
ALTkey as my $mod value and my Hex keybind set toCTRL + \, and while testing Hex, I ran into this problem below:So, I asked my agent to fix it, and I tested the whole thing locally to ensure it works as you do expect. And now I'm able to use Hex flawlessly on my machine. So, I'm raising this PR in hopes of fixing it for anyone else who runs into the same situation. And I have also pasted a description of the entire PR made by my agent so you can understand the technical parts of it.
Description
flowchart LR A["Hold hotkey Start"] --> B["Grab Escape for cancel"] B --> C{"Grab result"} C --> D["Success: enable Escape-cancel"] C --> E["BadAccess: warn, dictate without cancel"] C --> F["Other error: stop listener"]Validation (CONTRIBUTING.md checklist, EndeavourOS i3/X11 host)
cargo fmt --check- cleancargo test- 151 passed, 0 failed, 8 ignored (keyboard-layout test skips, macOS-only)cargo clippy --all-targets --all-features -- -D warnings- cleangit diff --check- cleanListeningwith no error; real dictation completed afterward