Repository navigation
Skip redundant SHA-256 hashing and GCS existence check in getOrUploadApk - #102
Merged
Merged
Conversation
Previously, when getOrUploadApk missed GCS, calling apkStore.uploadApk(name, bytes) re-computed SHA-256 over the full APK byte array (even though sha256 was already known from TestRunConfig) and queried googleCloudApi.existingFilePath() a second time before uploading. - Add ApkStore.getOrUploadApk(name, sha256, bytes) that checks GCS existence once using the provided sha256 and uploads directly via putApk on a miss. - Route TestRunnerServiceImpl.getOrUploadApk and TestScheduler.PendingApk through ApkStore.getOrUploadApk. - Track existingFilePath queries in FakeGoogleCloudApi and add unit tests in ApkStoreTest and TestRunnerServiceImplTest. Test: ./gradlew :lib:ktlintCheck :lib:test
rnakade
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when getOrUploadApk missed GCS, calling apkStore.uploadApk(name, bytes) re-computed SHA-256 over the full APK byte array (even though sha256 was already known from TestRunConfig) and queried googleCloudApi.existingFilePath() a second time before uploading.
Test: ./gradlew :lib:ktlintCheck :lib:test