Skip to content

Cleanup IMPORT_BRUSH Intent#84

Draft
maxmmitchell wants to merge 1 commit into
mainfrom
fix-intent
Draft

Cleanup IMPORT_BRUSH Intent#84
maxmmitchell wants to merge 1 commit into
mainfrom
fix-intent

Conversation

@maxmmitchell

@maxmmitchell maxmmitchell commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Avoid navigating to brush graph when we're already there for a smoother experience. And go to brush graph even if the brush fails to be imported.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the brush import flow by triggering navigation to the brush graph before the import operation begins and adding a safety check in CahierApp.kt to prevent redundant navigation. The reviewer correctly pointed out that navigating before the import completes or if it fails can lead to an inconsistent UI state, and suggested reverting this change to ensure navigation only occurs upon a successful import.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread app/src/main/java/com/example/cahier/MainActivity.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant