Support new color functions for HSL shift#83
Conversation
There was a problem hiding this comment.
Code Review
This pull request expands the color function capabilities in the brush graph UI by adding support for hue offset, saturation multiplier, and luminosity offset. It refactors the display string resolution for ProtoColorFunction into an extension function and updates the corresponding UI fields, tooltips, and tests. Feedback on the changes includes fixing a UI rendering bug where an empty or default ProtoColorFunction results in no numeric field being displayed, displaying the luminosity offset as a percentage instead of a raw float for consistency, and explicitly checking hasLuminosityOffset() in displayStringRId() for better code readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
399e514 to
7c434c8
Compare
7c434c8 to
31a0336
Compare
With
1.1.0-alpha04, we got new color functions:This change adds support for these color functions in brush graph, so we can load brushes that use these new features, and edit them. A lot of formatting changes also got picked up on save in
TooltipsTest.kt.