Upgrade to Ink 1.1.0-alpha04#82
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the ink library version to 1.1.0-alpha04 in the Gradle dependencies and improves the documentation in brush_family.proto. The proto documentation updates clarify default behaviors, specify incompatibilities with SELF_OVERLAP_DISCARD, provide examples for forward and lateral position offsets, and update validation rules to match the individual start and end range fields. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
58f3cd9 to
51f2249
Compare
Fix build error Fix build error
51f2249 to
d9e0e6c
Compare
Upgrade to the latest version of Ink as of this PR, and pull over recent updates to
brush_family.protofrom Ink's Github. Most applicable changes from this version increase for Cahier are:BrushBehavior.developerCommentis now supported in the programmatic API, which will make the transition to programmatic APIs from proto builders easier.ColorFunctionsare available (hue, saturation, and luminosity offsets).BrushFamily.decodenow accepts callbacks which takeByteArray?too, which prompted me to take a closer look at our calls toencode/decode. To avoid the ambiguous callsite, added typing to the callback params as well as generally standardizing calls across Cahier to be a bit more Kotlin idiomatic in our usage of the Ink storage serialization API.