Skip to content

Upgrade to Ink 1.1.0-alpha04#82

Merged
maxmmitchell merged 2 commits into
mainfrom
upgrade-ink-110alpha04
Jun 22, 2026
Merged

Upgrade to Ink 1.1.0-alpha04#82
maxmmitchell merged 2 commits into
mainfrom
upgrade-ink-110alpha04

Conversation

@maxmmitchell

@maxmmitchell maxmmitchell commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Upgrade to the latest version of Ink as of this PR, and pull over recent updates to brush_family.proto from Ink's Github. Most applicable changes from this version increase for Cahier are:

  • BrushBehavior.developerComment is now supported in the programmatic API, which will make the transition to programmatic APIs from proto builders easier.
  • New ColorFunctions are available (hue, saturation, and luminosity offsets).
  • Several bug fixes and documentation improvements.

BrushFamily.decode now accepts callbacks which take ByteArray? too, which prompted me to take a closer look at our calls to encode/decode. To avoid the ambiguous callsite, added typing to the callback params as well as generally standardizing calls across Cahier to be a bit more Kotlin idiomatic in our usage of the Ink storage serialization API.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ink library version to 1.1.0-alpha04 in the Gradle dependencies and improves the documentation in brush_family.proto. The proto documentation updates clarify default behaviors, specify incompatibilities with SELF_OVERLAP_DISCARD, provide examples for forward and lateral position offsets, and update validation rules to match the individual start and end range fields. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@maxmmitchell maxmmitchell force-pushed the upgrade-ink-110alpha04 branch 3 times, most recently from 58f3cd9 to 51f2249 Compare June 18, 2026 13:52
Fix build error

Fix build error
@maxmmitchell maxmmitchell force-pushed the upgrade-ink-110alpha04 branch from 51f2249 to d9e0e6c Compare June 18, 2026 13:53
@maxmmitchell maxmmitchell marked this pull request as ready for review June 18, 2026 15:37

@cka-dev cka-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxmmitchell maxmmitchell merged commit 8332eab into main Jun 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants