Repository navigation
Name the amuleapi fields behind the remote-folder and local-only rules - #259
Merged
Merged
Conversation
Document the read-only directories.allowed_remote_roots preference and the three daemon-local fields that answer 400 read_only_field. The rest of amule-org#253 was already documented. Closes amule-org#253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253.
Most of #253 was already covered by #255. I checked each point again against the code at the
3.2.0tag. The only gap was theamuleapifield names.allowed-remote-dirs.datin config files,directories.md,amuled.md, troubleshootingamulegui: the read-only Folders the daemon allows remote changes in list, and refused changesamulegui.mdandpreferences.md)403 path_not_alloweddirectories.allowed_remote_rootsfieldamule.conf(FFProbePath,OSDirectory,FollowSymlinksInShares),amulegui.md,preferences.md400 read_only_field--allow-guest/--deny-guest,AllowGuest,GuestPassword,UseLowRightsUser, troubleshooting)server-met.md,nodes-dat.md,file-formats/index.md,IPFilterURL)ftp://localhost/fastservers.metexample is goneThe only change is in
amuleapi/index.md, under Security Model:directories.allowed_remote_rootspreference (PrefAccess::ReadOnlyinsrc/webapi/PrefsSchema.cpp).400 read_only_fieldarefiles.ffprobe_path,online_signature.directoryanddirectories.follow_symlinks(PrefAccess::DaemonLocal).npm run build -- --locale enbuilds with no errors and no broken links.