Repository navigation
Mention servers.update_urls next to the amuleapi server-list update - #258
Merged
Merged
Conversation
The rest of the server-list sources work asked for in amule-org#251 was already documented. Closes amule-org#251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251.
Most of #251 was already covered by #255. I checked each point again against the code at the
3.2.0tag. The only part still missing was the optionalamuleapinote.amule.conf:Ed2kServersUrlrow and example line removed, pointing toaddresses.datserver.metandaddresses.datsectionsaddresses.datis the only list, used for every update, one URL per line, comments ignoredserver.metfile format: "Obtaining server.met online"networks_upper_ed2k.pngscreenshotservers.update_urlsnext toservers_updateThe only change is in
amuleapi/index.md.POST /api/v1/servers_updatewithout a body downloads every source in theservers.update_urlspreference, in order. With aurl, it downloads that one list without saving it (src/webapi/Api.cpp,EC_OP_SERVER_UPDATE_FROM_URLinExternalConn.cpp).npm run build -- --locale enbuilds with no errors and no broken links.