tests: accept staged Cray MPICH in Comm_Backends provenance - #188
Merged
Conversation
Collaborator
|
Good to get this to pass with Cray MPICH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
MPI PROVENANCE:verdict toPytorch_Comm_Backends_Checkanduses that verdict as the CTest pass criterion.
The existing
GPU-AWARE MPI:line is left unchanged as the strict OpenMPIdiagnostic. The new provenance verdict applies Bob's 3 September rule: pass
when PyTorch is using either GPU-aware OpenMPI from the loaded module or a
staged Cray/MPICH-family MPI, and fail when it resolves to OS/system MPI or an
unrecognised MPI.
Why
After PR187, Tcl Environment Modules can be parsed correctly, but AAC7 still
fails the original gate honestly because the site PyTorch is linked to staged
Cray MPICH rather than the loaded OpenMPI module. That is not an OS MPI leak.
The new gate keeps the OpenMPI diagnosis visible while changing the CTest
decision to the intended provenance rule.
Validation
Pytorch_Comm_Backends_Checkpassed withMPI PROVENANCE: OKfor staged Cray MPICH.gate,
Regex=[MPI PROVENANCE: OK].before the new provenance line was identical; with this PR's CTest rule, the
added
MPI PROVENANCE: OKline matched the pass expression and the testpassed.