Repository navigation
probe: remove obsolete bridge name - #88
Merged
Merged
Conversation
With the migration to argp and a generic connection struct the bridge name argument became obsolete, but wasn't removed. Unfortunately, the passed argument "interface" is not the bridge name, but e.g. the UART device-path, which in the end meant that any driver that didn't match the path was skipped. Remove the argument as it isn't properly used anymore after the migration. Fixes: a120c4f ("cmd: probe: rework to argp and common connection struct") Signed-off-by: Tan Siewert <tan.siewert@9elements.com>
sinuscosinustan
force-pushed
the
fix-debug-uart-probe
branch
from
August 19, 2026 11:22
283ebb7 to
7230380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the migration to argp and a generic connection struct the bridge name argument became obsolete, but wasn't removed. Unfortunately, the passed argument "interface" is not the bridge name, but e.g. the UART device-path, which in the end meant that any driver that didn't match the path was skipped.
Remove the argument as it isn't properly used anymore after the migration.
Fixes: a120c4f ("cmd: probe: rework to argp and common connection struct")