fix: register RepomixConfigAssessor in create_all_assessors#404
Conversation
RepomixConfigAssessor existed in assessors/repomix.py but was never imported or added to create_all_assessors(), causing the attribute validator to reject repomix_config as an unknown ID. Also fixes three unit tests in test_repomix.py that created output files in the repo root instead of the repomix/ subdirectory, which is where RepomixService.get_output_files() now looks. Closes #400 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
Assessor Registration src/agentready/assessors/__init__.py |
RepomixConfigAssessor is imported and appended to the assessors list at the 2% weight tier. |
Test Setup Alignment tests/unit/test_repomix.py |
Three test functions now create and use tmp_path / "repomix" subdirectory for output files (repomix-output.md, repomix-output.xml) instead of writing directly to tmp_path. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately summarizes the primary change: registering RepomixConfigAssessor in create_all_assessors, which directly addresses the linked issue #400. |
| Description check | ✅ Passed | The description clearly explains what was changed (imports/registers RepomixConfigAssessor and fixes unit test file paths) and provides concrete test results demonstrating the fix works. |
| Linked Issues check | ✅ Passed | The PR fully addresses issue #400 by registering RepomixConfigAssessor in create_all_assessors() to make repomix_config a recognized attribute ID, and fixes the three failing unit tests in test_repomix.py by correcting file path expectations. |
| Out of Scope Changes check | ✅ Passed | All changes directly address the objectives from issue #400: registering the assessor and fixing unit test file paths. No out-of-scope changes are present. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/register-repomix-config-assessor
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
📈 Test Coverage Report
Coverage calculated from unit tests only |
|
🎉 This PR is included in version 2.35.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
RepomixConfigAssessorincreate_all_assessors()sorepomix_configis recognized as a valid attribute IDtest_repomix.pythat placed output files in the repo root instead of therepomix/subdirectory whereRepomixService.get_output_files()looksTest plan
pytest tests/e2e/test_critical_paths_simplified.py::TestCriticalConfigHandling::test_valid_config_applicationnow passespytest tests/unit/test_repomix.pyall 21 tests passagentready assess .showsrepomix_configin results (previously absent)Closes #400
🤖 Generated with Claude Code under the supervision of Bill Murdock