Skip to content

fix: register RepomixConfigAssessor in create_all_assessors#404

Merged
kami619 merged 1 commit into
mainfrom
fix/register-repomix-config-assessor
May 8, 2026
Merged

fix: register RepomixConfigAssessor in create_all_assessors#404
kami619 merged 1 commit into
mainfrom
fix/register-repomix-config-assessor

Conversation

@jwm4
Copy link
Copy Markdown
Contributor

@jwm4 jwm4 commented May 8, 2026

Summary

  • Imports and registers RepomixConfigAssessor in create_all_assessors() so repomix_config is recognized as a valid attribute ID
  • Fixes three unit tests in test_repomix.py that placed output files in the repo root instead of the repomix/ subdirectory where RepomixService.get_output_files() looks

Test plan

  • pytest tests/e2e/test_critical_paths_simplified.py::TestCriticalConfigHandling::test_valid_config_application now passes
  • pytest tests/unit/test_repomix.py all 21 tests pass
  • Full test suite passes (1149 passed, 21 skipped)
  • agentready assess . shows repomix_config in results (previously absent)

Closes #400

Note: a follow-up issue (#403) tracks adding repomix_config to default-weights.yaml and fixing the separation_concerns typo in that file.

🤖 Generated with Claude Code under the supervision of Bill Murdock

RepomixConfigAssessor existed in assessors/repomix.py but was never
imported or added to create_all_assessors(), causing the attribute
validator to reject repomix_config as an unknown ID.

Also fixes three unit tests in test_repomix.py that created output
files in the repo root instead of the repomix/ subdirectory, which
is where RepomixService.get_output_files() now looks.

Closes #400

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: String must contain at most 250 character(s) at "tone_instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: c7f4ebba-9869-4798-a5f4-cbf938fe62ae

📥 Commits

Reviewing files that changed from the base of the PR and between 3faebec and 82b22aa.

📒 Files selected for processing (2)
  • src/agentready/assessors/__init__.py
  • tests/unit/test_repomix.py

Walkthrough

RepomixConfigAssessor is registered in the assessor factory via import and list addition. Unit tests are updated to place generated output files in a repomix/ subdirectory instead of directly in tmp_path.

Changes

Assessor Registration & Test Alignment

Layer / File(s) Summary
Assessor Registration
src/agentready/assessors/__init__.py
RepomixConfigAssessor is imported and appended to the assessors list at the 2% weight tier.
Test Setup Alignment
tests/unit/test_repomix.py
Three test functions now create and use tmp_path / "repomix" subdirectory for output files (repomix-output.md, repomix-output.xml) instead of writing directly to tmp_path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary change: registering RepomixConfigAssessor in create_all_assessors, which directly addresses the linked issue #400.
Description check ✅ Passed The description clearly explains what was changed (imports/registers RepomixConfigAssessor and fixes unit test file paths) and provides concrete test results demonstrating the fix works.
Linked Issues check ✅ Passed The PR fully addresses issue #400 by registering RepomixConfigAssessor in create_all_assessors() to make repomix_config a recognized attribute ID, and fixes the three failing unit tests in test_repomix.py by correcting file path expectations.
Out of Scope Changes check ✅ Passed All changes directly address the objectives from issue #400: registering the assessor and fixing unit test file paths. No out-of-scope changes are present.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/register-repomix-config-assessor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

📈 Test Coverage Report

Branch Coverage
This PR 72.5%
Main 72.3%
Diff ✅ +0.2%

Coverage calculated from unit tests only

@jwm4 jwm4 requested a review from kami619 May 8, 2026 12:46
@kami619 kami619 merged commit c354d10 into main May 8, 2026
10 checks passed
@kami619 kami619 deleted the fix/register-repomix-config-assessor branch May 8, 2026 13:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🎉 This PR is included in version 2.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing e2e test: repomix_config not registered in create_all_assessors

2 participants