Repository navigation
evidence-replay: pin EXPECTED_14 to main f5efa7a0 (same blob 61cfd6ea) - #1129
Conversation
…ad (#941) EXPECTED_14 (4a260ca) is not reachable from main; it lives only on #918's branch and refs. The same expected result, blob 61cfd6e at papers/introduction_repro/results-121598983127.json, landed on main with #1124 (merge f5efa7a): git rev-parse f5efa7a:papers/introduction_repro/results-121598983127.json = 61cfd6e = EXPECTED_14_BLOB. EXPECTED_14_BLOB, the 14-module comparison and every other pin are unchanged; EXPECTED_28 (e73f7be) is deliberately untouched. Header comment updated to match. Owner decision #941 c.6658483078. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
|
Independent review of Scope: owner decision #941 c.6658483078, item EXPECTED_14. Checked on a fresh, non-shallow 1. Diff (
|
| Step | Exit |
|---|---|
git cat-file -e LEAN_COMMIT / ARCHIVE_COMMIT / EXPECTED_14 (f5efa7a0) / EXPECTED_28 (e73f7be3) |
0 / 0 / 0 / 0, so no git fetch was needed for any of them |
git update-ref refs/remotes/origin/main "$LEAN_COMMIT" |
0 |
git worktree add --detach "$RUNNER_TEMP/dir" "$LEAN_COMMIT" |
0 |
test "$(git -C … rev-parse HEAD)" = "$LEAN_COMMIT" |
0 |
test ! -e …/verification/lean-mathlib/.lake |
0 |
git show "$ARCHIVE_COMMIT:…/extract_result.py" and …/compare_result.py |
0, 0 |
:88 test "$(git rev-parse "$EXPECTED_14:…json")" = "$EXPECTED_14_BLOB" |
0 |
:89 the same for EXPECTED_28 |
0 |
:90 git show "$EXPECTED_14_BLOB" → expected-14.json |
0. It is 64,105 bytes, re-hashes to 61cfd6ea, and holds 14 modules. |
:91 git show "$EXPECTED_28_BLOB" → expected-28.json |
0. It is 114,828 bytes, re-hashes to 97a2377d, and holds 28 modules. |
So EXPECTED_14 now resolves from main alone. EXPECTED_28 still resolves only because the staging branch exists; this PR leaves that unchanged, as decided. This is a retrieval check only. Whether the lean-fresh-build job succeeds end to end is not established without a separately authorized dispatch.
4. Other references to the old value
- Mutable files at the head:
git grep 4a260cafinds onlyevidence-replay.yml:15, the new header's "first carried at Introduction paper: reconcile sources and integrate scoped theorem recoveries #918's head 4a260ca" (N1). No other file referencesEXPECTED_14,EXPECTED_28or their values. - Frozen or historical records:
verification/audits/manuscript/foundational-release-20261028/candidate-inputs.json:6 pinsevidence-replay.ymlby sha256 (240b97e1…). That is the file atmain13ced581; at528966ffit hashes to866a2548…. That file is a point-in-time pin of that candidate's inputs, not a live invariant. ItsAGENTS.mdandverify.ymlentries already differ frommain, and no tool or check reads it, since the only reference is its own README:37. No edit is proposed. legacy-records.jsondoes not list it.
5. PR CI (verify, pull_request)
Run 42031085409, attempt 1, head_sha 528966ff: status: completed, conclusion: success. Of 26 check runs, 25 are success and 1 is skipped. The skipped one is the unexpanded matrix placeholder "Numerical probes / A42 exclusion (${{ matrix.part }})". Mathlib bridge (the release gate), Lean kernel check and the aggregate Numerical probes are all success. This run tests the synthetic merge with main 13ced581. It is not an exact-head attestation and is not needed as one for this unit. evidence-replay.yml itself is workflow_dispatch-only and did not run.
Findings
- N1 (optional, comment wording only). "first carried at Introduction paper: reconcile sources and integrate scoped theorem recoveries #918's head 4a260ca" is not accurate as history. Blob
61cfd6eafirst appears on Introduction paper: reconcile sources and integrate scoped theorem recoveries #918's branch at3941ef88. The file was added ated3ca911asbd8630fc. Onmain, the blob first enters through40fc5954, underf5efa7a0.4a260ca9is where the workflow first pinned it. "first pinned at Introduction paper: reconcile sources and integrate scoped theorem recoveries #918's head 4a260ca" would be exact. This is not load-bearing, and no check reads it. Fixing it means a new head, with re-review and CI. - No blocking findings. The change is the minimum one the owner's decision describes. It preserves the verified blob, and it makes the
EXPECTED_14path rest onmain(§A.42 items 2–3).
Merge and any evidence-replay.yml dispatch remain separately gated owner decisions. This review grants neither.
Generated by Claude Code
…w nit N1, #1129) The blob first appears on #918's branch at 3941ef8; 4a260ca is where the workflow first pinned it. Comment only; no pin or check changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
|
Delta check
My findings in the earlier review (c.6658681447) all carry over to this head unchanged. Merge and any Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
|
Owner merge approval (amaybaum, Claude Code session chat, 2026-11-05; quoted under §A.42 item 7): Integration checkpoint.
Generated by Claude Code |
|
Owner standing rule and conditional approvals (amaybaum, Claude Code session chat, 2026-11-05; quoted under §A.42 item 7):
Generated by Claude Code |
|
Merge record (standing integration rule, c.6659123095) Merged at integrated head Conditions checked immediately before merging:
The head branch was deleted automatically on merge. Its commits remain reachable as the merge's second parent. Generated by Claude Code |
Draft. Merge not authorized; no dispatch authorized. The owner decides on the exact reviewed SHA separately. Authority: owner decision #941 c.6658483078; plan c.6658442142.
Problem
.github/workflows/evidence-replay.ymlpinsEXPECTED_14: 4a260ca9…, which is #918's head. That commit is not reachable frommain; it exists only on #918's branch and refs (#941 c.6658258907). The expected result it carries, blob61cfd6eaatpapers/introduction_repro/results-121598983127.json, landed onmainwith #1124 (mergef5efa7a0).Change (head
0a07d8a9, two commits onmain13ced581)528966ff:EXPECTED_14: 4a260ca9d6414e4d504a629ba5a0eb3c70bd4704→EXPECTED_14: f5efa7a0813218b580272f7fd80a6b0c87eb6657, with the matching header comment.0a07d8a9: the comment says "first pinned at Introduction paper: reconcile sources and integrate scoped theorem recoveries #918's head 4a260ca", per review nit N1. It is a comment-only change.EXPECTED_14_BLOB(61cfd6ea…);EXPECTED_28(e73f7be3) is untouched, per the owner's decision.Verification
f5efa7a0:<path>=61cfd6ea…;f5efa7a0is an ancestor ofmain;expected-14.jsonre-hashes to61cfd6ea, with 14 modules;expected-28still resolves only through the staging branch.528966ff: run 42031085409 succeeded.0a07d8a9and CI at that head.evidence-replay.ymlruns only onworkflow_dispatch. A dispatch to confirmlean-fresh-buildend to end would need separate owner approval.Out of scope, noted by the review
verification/audits/manuscript/foundational-release-20261028/candidate-inputs.json:6 pins the workflow's old sha256. It is a point-in-time candidate record whose other hashes already differ frommain. No tool reads it, and it is not a legacy record. It is left unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq