Skip to content

docs: point README, build.sh and the Zenodo description at the Introduction paper - #1127

Merged
amaybaum merged 6 commits into
mainfrom
docs/introduction-readme-20261105
Nov 5, 2026
Merged

amaybaum merged 6 commits into
mainfrom
docs/introduction-readme-20261105

Conversation

@amaybaum

@amaybaum amaybaum commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Draft. Merge is not authorized; the owner decides separately.

This PR updates the README and other documentation for the Introduction paper, which landed in #1124 (f5efa7a0), at the owner's request. It also redraws the README's correspondence diagram, which the owner asked for.

Changes (head 6f4073b8; net diff against main 5e35eb88)

  • README.md
    • "Start here": new first row, "A short introduction to the framework's finite-observer results → papers/Introduction.md".
    • "Other materials in papers/": new entry describing the paper within its own scope. It points to Appendix A, which lists the Lean declarations the paper cites and their verification status. It also points to papers/introduction_repro/, which holds the axiom reports for the paper's baseline declarations and the recipe that reproduces them.
    • "The foundational correspondence": the text block is now a left-to-right Mermaid flowchart, S ⇄ D ⇄ Q_fb, with thick two-way arrows and no labels. The node labels match the old text block word for word. The sentence below the diagram still states the equivalence.
  • build.sh: the usage comment "build everything (12 papers + book)" now says 13, matching the 13 papers/*.md on main. Behaviour is unchanged.
  • .zenodo.json: the description now lists "the introductory paper Introduction (an introductory entry point to the finite-observer results)" among the papers. The file is still valid JSON, and description is its only changed key.

Review

  • Short independent review: ACCEPT WITH CHANGES (c.6656883592). It confirmed:
    • the scope is only these three files;
    • the README text claims nothing beyond what the paper itself says;
    • the diagram is consistent with the surrounding text;
    • book/README.md:110 ("twelve technical papers") is correct as it stands;
    • SC-42 passes.
  • Requested wording changes, applied in 6f4073b8:
    • "self-contained" is dropped, because the paper refers readers to Main and the companions for the core proofs;
    • the axiom reports are scoped to the baseline declarations.
  • Next: a delta check of 6f4073b8 and CI at this head.

Deliberately unchanged

🤖 Generated with Claude Code

https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq

…uction paper

README: a 'Start here' row and an entry under 'Other materials in
papers/' for papers/Introduction.md and papers/introduction_repro/.
build.sh: the build-everything comment counts 13 papers. .zenodo.json:
the description lists the Introduction among the papers. No manuscript,
book or verification file changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
…iagram

Same three descriptions and the same two 'exact' links as the text
block it replaces; GitHub renders it as a flowchart. Rendered and
checked with Mermaid 10.9.1 before committing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
flowchart LR instead of TB, with the Q_fb label wrapped onto two lines
so the row stays compact. Content unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
Owner request: the S <-> D <-> Q_fb links are drawn as thick
bidirectional arrows (<==>) without labels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq

amaybaum commented Nov 5, 2026

Copy link
Copy Markdown
Owner Author

Independent review at head 1fa82546: ACCEPT WITH CHANGES. Two small wording fixes and a stale PR description. Nothing blocks the merge on substance.

Checked and OK

  • Scope. The net diff against main 5e35eb88 touches only README.md (+7/−5), build.sh (one usage comment line) and .zenodo.json. .zenodo.json parses, and description is the only key that changed.
  • build.sh. main has 13 papers/*.md files, and the no-argument for md in papers/*.md loop builds all of them, so "13 papers + book" is correct.
  • Introduction descriptions. The "Start here" row and the topic list in the "Other materials" entry match the paper's abstract and §§2.2, 2.4, 2.5 and 5. "Appendix A … with their verification status" matches the appendix title. Nothing is called proved or machine-checked beyond what the paper says. papers/introduction_repro/ exists on main.
  • Mermaid diagram. flowchart LR with three nodes (S, D, Q_fb) and two unlabelled <==> links; the syntax looks valid. I checked it by inspection only and did not render it. The three descriptions match the old text block word for word. With the "exact" labels gone, the diagram shows a two-way link, which agrees with the sentence below it ("The representation equivalence is universal at this finite-record level") and with the S ⟺ D ⟺ Q_fb entry in the Core papers table.
  • book/README.md:110. "twelve technical papers" is correct: no book chapter draws on the Introduction. No other README-like file lists every paper. book/bibliography.md:9 paraphrases the old Zenodo list, but it is a book manuscript and already leaves out Computation, so it needs no change here.
  • Hygiene. The added lines contain no local paths and no scratch-area wording. check_sc42_integration.py in a detached worktree of the head: verdict: PASS, 689 checks ok, 0 failed.

Changes requested (wording only)

  1. "self-contained". The README entry says "short, self-contained introduction" and .zenodo.json says "a self-contained entry point". The paper never calls itself self-contained, and §1.2 sends the reader to [Main] for the core arguments: "The core finite-law and memory arguments are in [Main]; proofs and qualifications also occur in the companion papers…". Suggest "standalone" or "introductory", or dropping the adjective.
  2. Scope of the axiom reports. "the axiom reports and the recipe that reproduces them are in papers/introduction_repro/" reads as if it covered every declaration in Appendix A. The repro covers only the 28 baseline declarations at 17b830bc. The paper's Code section separates out the four additional modules (RecordFibreIdentification, RootedRecurrenceBridge, TrajectoryMemory, FullFutureMemory): they are built on main, and their proofs have not been independently reviewed. Suggest "…the axiom reports for its baseline declarations, and the recipe that reproduces them, are in …".
  3. PR description is stale. It still names head f99e3d8a and says each link is labelled "exact". Please update it to the current head and the unlabelled <==> links.

CI at 1fa82546 (run 42019215000): still running when I checked. Lean kernel check and 15 probe jobs have passed, one matrix job was skipped, and none has failed. Mathlib bridge, core A/B and seven other probe jobs were still running.


Generated by Claude Code

- README and .zenodo.json no longer call the paper 'self-contained' (it
  sends readers to Main and the companions for the core proofs).
- README: the axiom reports in papers/introduction_repro/ are for the
  paper's baseline declarations only.
Per review #1127 c.6656883592.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq

amaybaum commented Nov 5, 2026

Copy link
Copy Markdown
Owner Author

Delta review, 1fa82546 → 6f4073b8: ACCEPT.

  • Only the two requested wording fixes. The commit touches two files, one line each:
    • .zenodo.json: "(a self-contained" → "(an introductory".
    • README.md, Introduction entry: "short, self-contained" → "short"; "the axiom reports for its baseline declarations, and the recipe that reproduces them, are in …".
    • The only "self-contained" left in README.md is the Juno row on Start here, which was already on main. The added lines contain no local paths or scratch-area wording.
  • .zenodo.json parses. Against main 5e35eb88, the only key that differs is description. The net diff against main is still only README.md, build.sh and .zenodo.json.
  • SC-42 at 6f4073b8, run in a detached worktree: verdict: PASS, with 0 failed checks.
  • PR CI at 6f4073b8: verify run 42019670604 finished with conclusion success.

This resolves the three findings from my earlier comment (#issuecomment-6656883592), provided the PR description is updated as planned.


Generated by Claude Code

@amaybaum
amaybaum marked this pull request as ready for review November 5, 2026 11:53
@amaybaum
amaybaum merged commit c88293e into main Nov 5, 2026
26 checks passed
@amaybaum
amaybaum deleted the docs/introduction-readme-20261105 branch November 5, 2026 11:53

amaybaum commented Nov 5, 2026

Copy link
Copy Markdown
Owner Author

Merge record.

  • Merge: c88293e4f0a20af2c1a290f77ba1d9c3bda600ab, a normal merge commit with expectedHeadSha 6f4073b8. The owner's approval is quoted on Introduction paper: reconcile sources and integrate scoped theorem recoveries #918 (c.6657303442).
    • Parents: 5e35eb88 (main) and 6f4073b8 (the reviewed head).
    • The merge tree equals 6f4073b8's tree.
    • The net change touches only README.md, build.sh and .zenodo.json. Both approved wording corrections are intact.
  • Reviews: short review c.6656883592, then a delta check, ACCEPT (c.6657092310). PR CI run 42019670604 at 6f4073b8 was green.
  • main CI: push run 42022612501 on c88293e4 concluded success. That includes the Mathlib bridge release gate, whose legacy-records step confirms the 303 legacy records are intact.

Generated by Claude Code

amaybaum pushed a commit that referenced this pull request Nov 5, 2026
…ness-20261102

Refresh #1036 against current main after #1145. README.md auto-merged without
conflict: main's edits (#1127, #1134, #1140/#1145 and earlier) left the
introductory sentence untouched, so the branch's one-line correction applies
unchanged and is the only difference from main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zDyUSyEszk3JJx83uXKKq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants