Public export snapshot from bran-dev 0a1de91 (fix Rekor time extraction) - #10
Merged
Conversation
Read the Rekor inclusion time from either cosign bundle shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public export snapshot from a clean committed source.
0a1de91258669123a3488af9b20d47a4d16b53c28517307Why
The previous release run built all five platforms successfully and cosign keyless signing succeeded, but the manifest step failed with
KeyError: 'logEntry'.cosign sign-blob --bundlewrites the legacy cosign bundle (rekorBundle.Payload.integratedTime);--new-bundle-formatwrites a Sigstore v0.3 bundle (verificationMaterial.tlogEntries[].integratedTime, as a string). The code looked for neither shape.Now handles both, derives the signature asset's media type from whichever shape is actually present rather than asserting v0.3, and fails closed rather than publishing a manifest with an invented signing time.
Rebase-merge, not squash.