fix tr fileName duplicating - #794
Open
formaceft-93 wants to merge 1 commit into
Open
Conversation
Allure Report Summary
|
Allure perf metricsGenerated at:
Artifacts: allure-perf-metrics |
todti
approved these changes
Jul 16, 2026
formaceft-93
force-pushed
the
fix-retries
branch
from
July 28, 2026 08:50
c674b22 to
5801fb7
Compare
formaceft-93
force-pushed
the
fix-retries
branch
from
September 7, 2026 09:09
a619cfe to
9037cbe
Compare
vdvukhzhilov
reviewed
Sep 9, 2026
| return; | ||
| } | ||
|
|
||
| testResult.id = md5(`${raw.uuid}:${incomingFileName}`); |
Collaborator
There was a problem hiding this comment.
This mirrors the id assigning in testResultRawToState.
I think it is better to introduce something like calculateTRId(raw: RawTestResult, deps?: string[]) {} func that will be used both here and there.
So it will be the only source of truth for both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #616
Checklist