chore: post-merge follow-ups (region cleanup + landing tests)#45
Closed
AlexandreCamillo wants to merge 2 commits into
Closed
chore: post-merge follow-ups (region cleanup + landing tests)#45AlexandreCamillo wants to merge 2 commits into
AlexandreCamillo wants to merge 2 commits into
Conversation
The endpoint cropped a screenshot using pinCoords. After the comment-only annotation flow landed in PR #44, no new annotation row has either field set — the endpoint was unreachable for anything created after the cutover. Removing the route, the sharp-backed cropRegion helper, the unit test, sharp's pnpm "built-dependencies" entry, and every doc cross-reference (agent-loop endpoints + INDEX, api INDEX, feature catalog, stack, storage, routes, ci, frontend INDEX, task-rules, testing). Legacy annotation rows with screenshotPath + pinCoords populated will no longer be reachable through this URL — orchestrators relying on it should fetch the full screenshot via /api/annotations/[id]/screenshot.
The two failing landing.spec.ts tests still looked for a "Drop pin"
button that has not existed since the ViewerShell migration. The
demo's create-annotation flow now: click "New annotation" → click
inside the iframe (title="Mockup") → fill the draft textarea ("Annotation
body") → click "Send" → annotation card appears with data-pin-target.
Drops the window.prompt mock (the old DraftCard used prompt, the new
one is a real textarea). Reset test uses the same flow to seed a 4th
annotation before exercising the two-click reset.
Coverage report
|
Collaborator
Author
|
Superseded by #47 — consolidando os dois PRs lá. Disposição dos dois commits desta branch após análise contra o
Fechando este PR; o trabalho relevante segue no #47. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-ups from PR #44 (tldraw removal + ViewerShell extraction) that we explicitly parked.
Commits
649a9c1— removeGET /api/annotations/[id]/regionand the sharp-backedcropRegionhelper. The endpoint cropped a screenshot usingpinCoords; since the comment-only annotation flow landed in refactor: tldraw removal + ViewerShell extraction #44 no new annotation row has either field set, so this URL became unreachable for anything created after the cutover. Touches: route file, lib helper, unit test,sharppnpmonlyBuiltDependenciesentry, plus 11 doc cross-refs (agent-loop endpoints + INDEX, api INDEX + routes + storage, feature catalog, stack, ci, frontend INDEX, task-rules, testing).2fe71e7— rewrite the two failinglanding.spec.tstests. They still looked for aDrop pinbutton that has not existed since the ViewerShell migration. New flow: click "New annotation" → click iframe → fill "Annotation body" textarea → click "Send" → assertdata-pin-targetcount. Drops the now-unusedwindow.promptmock.Acceptance
Out of scope