This repository was archived by the owner on Jul 12, 2019. It is now read-only.
Sticky Menu (earlier: Fixed broken snapshots for cells with background views) - #65
Open
benjaminjackson wants to merge 4 commits into
Open
Sticky Menu (earlier: Fixed broken snapshots for cells with background views)#65benjaminjackson wants to merge 4 commits into
benjaminjackson wants to merge 4 commits into
Conversation
Owner
|
Thanks for the report and PR @benjaminjackson, I hope to have some time to look at it during the weekend. I'll keep you informed. |
…(e.g. Apple Mail-style "Archive" button).
Author
|
Just realized I still had this pull open and pushed some other, unrelated changes to master, so this pull now includes a new "sticky menu" mode that will mimic Apple Mail's Archive button. I started going to the trouble of opening a new branch and rebasing but am not amazing at git so feel free to cherry-pick either or both of the commits in the pull. |
benjaminjackson
changed the title
…or to appear with partial transparency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't 100% ready but wanted to float it out there in case anyone has ideas: I fixed the bug where cells with background views don't display when swiping.
There's a catch, though: the separators aren't rendering in the simple case (no background view), which looks weird when the color background highlights itself—i.e. the separator turns green when hitting the trigger point.
Any suggestions for how to fix this pull to the point where it's worth accepting would be welcome.